linux-kernel - Re: [RFC PATCH 09/13] mfd: rtc: support RTC on ROHM BD71828 with BD70528 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1aa91f74b41033fed4a7106247f48f9b9f78bd9.camel@fi.rohmeurope.com>
Date:   Thu, 17 Oct 2019 10:36:44 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>
CC:     "dmurphy@...com" <dmurphy@...com>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "mazziesaccount@...il.com" <mazziesaccount@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "jacek.anaszewski@...il.com" <jacek.anaszewski@...il.com>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "pavel@....cz" <pavel@....cz>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>
Subject: Re: [RFC PATCH 09/13] mfd: rtc: support RTC on ROHM BD71828 with
 BD70528 driver

Hello Alexandre,

Thanks for quick check! I'll be off for the rest of the week but I will
re-work this patch at next week :) I agree with you regarding most of
the comments.

> > +
> > +
> > +/*
> > + * RTC definitions shared between
> > + *
> > + * BD70528
> > + * and BD71828
> > + */
> > +
> > +#define ROHM_BD1_MASK_RTC_SEC		0x7f
> > +#define ROHM_BD1_MASK_RTC_MINUTE	0x7f
> > +#define ROHM_BD1_MASK_RTC_HOUR_24H	0x80
> > +#define ROHM_BD1_MASK_RTC_HOUR_PM	0x20
> > +#define ROHM_BD1_MASK_RTC_HOUR		0x3f
> > +#define ROHM_BD1_MASK_RTC_DAY		0x3f
> > +#define ROHM_BD1_MASK_RTC_WEEK		0x07
> > +#define ROHM_BD1_MASK_RTC_MONTH		0x1f
> > +#define ROHM_BD1_MASK_RTC_YEAR		0xff
> > +#define ROHM_BD1_MASK_ALM_EN		0x7
> > +
> 
> All that renaming is distracting and useless. Please resubmit without
> renaming defines, structs and functions to make it easier to review.

I would prefer renaming because it makes it clearly visible which
defines/structs/functions are common for both PMICs and which are PMIC
specific. But I really understand the problem of spotting real changes.
Would it be Ok if I did renaming in separate patch which does not bring
in any other changes - and then the functional changes in separate
patch?

Best Regards
	Matti Vaittinen