linux-kernel - Re: [PATCH 1/3] auxdisplay: Make charlcd.[ch] more general

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Oct 2019 14:26:31 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Lars Poeschel <poeschel@...onage.de>
Cc:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        Willy Tarreau <willy@...roxy.com>,
        Ksenija Stanojevic <ksenija.stanojevic@...il.com>,
        open list <linux-kernel@...r.kernel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH 1/3] auxdisplay: Make charlcd.[ch] more general

On Thu, Oct 17, 2019 at 11:07 AM Lars Poeschel <poeschel@...onage.de> wrote:
> On Wed, Oct 16, 2019 at 06:53:20PM +0200, Miguel Ojeda wrote:
> > On Wed, Oct 16, 2019 at 10:24 AM Lars Poeschel <poeschel@...onage.de> wrote:

> > Thanks Lars, CC'ing Geert since he wrote a large portion of this, as
> > well as Andy.

I would be able to test next version if you Cc it to me (better to my
@linux.intel.com address).


> The idea with changing the return types: It seems a bit, that with this
> patch charlcd is becoming more of an universal interface and maybe more
> display backends get added - maybe with displays, that can report
> failure of operations. And I thought, it will be better to have this
> earlier and have the "interface" stable and more uniform. But you are
> the maintainer. If you don't like the changed return types I happily
> revert back to the original ones in the next version of the patch.

First rule of all, split as much as one logical change per patch. If
you wish to split, do simple split and nothing else. But I think you
also need to prepare something for the split. I would think of
introducing ops structure beforehand.

> Are you able to test the panel driver ?
I would be able to test on HD44780 connected via GPIO (4-bit mode).

-- 
With Best Regards,
Andy Shevchenko