linux-kernel - Re: [PATCH -next] iommu/amd: fix a warning in increase_address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <577A2A6B-3012-4CDE-BE57-3E0D628572CB@lca.pw>
Date:   Thu, 17 Oct 2019 07:36:51 -0400
From:   Qian Cai <cai@....pw>
To:     Jerry Snitselaar <jsnitsel@...hat.com>
Cc:     jroedel@...e.de, don.brace@...rosemi.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        jejb@...ux.ibm.com, esc.storagedev@...rosemi.com,
        linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org
Subject: Re: [PATCH -next] iommu/amd: fix a warning in increase_address_space



> On Oct 16, 2019, at 6:59 PM, Jerry Snitselaar <jsnitsel@...hat.com> wrote:
> 
> I guess the mode level 6 check is really for other potential callers
> increase_address_space, none exist at the moment, and the condition
> of the while loop in alloc_pte should fail if the mode level is 6.

Because there is no locking around iommu_map_page(), if there are several concurrent callers of it for the same domain, could it be that it silently corrupt data due to invalid access?