[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <25bb4857-950e-592a-b2ba-7730867742b3@redhat.com>
Date: Thu, 17 Oct 2019 12:41:34 +0100
From: Andrew Price <anprice@...hat.com>
To: "Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk>
Cc: linux-kernel@...ts.codethink.co.uk, cluster-devel@...hat.com,
linux-kernel@...r.kernel.org
Subject: Re: [Cluster-devel] [PATCH] gfs2: make gfs2_fs_parameters static
On 17/10/2019 12:02, Ben Dooks (Codethink) wrote:
> The gfs2_fs_parameters is not used outside the unit
> it is declared in, so make it static.
>
> Fixes the following sparse warning:
>
> fs/gfs2/ops_fstype.c:1331:39: warning: symbol 'gfs2_fs_parameters' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> ---
> Cc: Bob Peterson <rpeterso@...hat.com>
> Cc: Andreas Gruenbacher <agruenba@...hat.com>
> Cc: cluster-devel@...hat.com
> Cc: linux-kernel@...r.kernel.org
> ---
> fs/gfs2/ops_fstype.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
> index 681b44682b0d..ebdef1c5f580 100644
> --- a/fs/gfs2/ops_fstype.c
> +++ b/fs/gfs2/ops_fstype.c
> @@ -1328,7 +1328,7 @@ static const struct fs_parameter_enum gfs2_param_enums[] = {
> {}
> };
>
> -const struct fs_parameter_description gfs2_fs_parameters = {
> +static const struct fs_parameter_description gfs2_fs_parameters = {
> .name = "gfs2",
> .specs = gfs2_param_specs,
> .enums = gfs2_param_enums,
>
Looks good to me.
Thanks,
Andy
Powered by blists - more mailing lists