linux-kernel - Re: [PATCH 00/32] Kill pr_warning in the whole linux code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191017130550.nwswlnwdroyjwwun@pathway.suse.cz>
Date:   Thu, 17 Oct 2019 15:05:50 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Andy Whitcroft <apw@...onical.com>,
        "DavidS. Miller" <davem@...emloft.net>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        AlexeiStarovoitov <ast@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        GregKroah-Hartman <gregkh@...uxfoundation.org>,
        Joe Perches <joe@...ches.com>,
        ArnaldoCarvalho de Melo <acme@...hat.com>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/32] Kill pr_warning in the whole linux code

On Tue 2019-10-08 14:39:32, Kefeng Wang wrote:
> Hi all,
> 
> On 2019/10/2 16:55, Petr Mladek wrote:
> > Linus,
> > 
> > On Fri 2019-09-20 14:25:12, Kefeng Wang wrote:
> >> There are pr_warning and pr_warng to show WARNING level message,
> >> most of the code using pr_warn, number based on next-20190919,
> >>
> >> pr_warn: 5189   pr_warning: 546 (tools: 398, others: 148)
> > 
> > The ratio is 10:1 in favor of pr_warn(). It would make sense
> > to remove the pr_warning().
> > 
> > Would you accept pull request with these 32 simple patches
> > for rc2, please?
> > 
> > Alternative is to run a simple sed. But it is not trivial
> > to fix indentation of the related lines.
> 
> Kindly ping, should I respin patches with comments fixed?
> Is the patchset acceptable, hope to be clear that what to do next :)

I am going to check how many conflicts appeared in linux-next.

If there are only few then I'll take it via printk.git. This way
we get proper indentation and other changes.

If there are too many conflicts then I'll ask Linus to do a mass
change using a script.

I am sorry for late reply. I have never pushed such a mass change.
I hoped that anyone more experienced will provide some opinion ;-)

Best Regards,
Petr