linux-kernel - Re: [PATCH -next 00/30] pinctrl: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Oct 2019 15:09:02 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     linus.walleij@...aro.org, manivannan.sadhasivam@...aro.org,
        afaerber@...e.de, f.fainelli@...il.com, rjui@...adcom.com,
        sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
        jesper.nilsson@...s.com, lars.persson@...s.com,
        ludovic.desroches@...rochip.com, nicolas.ferre@...rochip.com,
        baruch@...s.co.il, linux-arm-kernel@...ts.infradead.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...s.com, linux-oxnas@...ups.io,
        linux-renesas-soc@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-tegra@...r.kernel.org, vz@...ia.com, narmstrong@...libre.com,
        geert+renesas@...der.be, daniel@...que.org,
        haojian.zhuang@...il.com, wens@...e.org, thierry.reding@...il.com,
        jonathanh@...dia.com, agross@...nel.org
Subject: Re: [PATCH -next 00/30] pinctrl: use
 devm_platform_ioremap_resource() to simplify code

Hi,

On 17/10/2019 20:26:10+0800, YueHaibing wrote:
> devm_platform_ioremap_resource() internally have platform_get_resource()
> and devm_ioremap_resource() in it. So instead of calling them separately
> use devm_platform_ioremap_resource() directly.
> 

Shouldn't we stop with this insanity? The net gain is exactly 2 lines
per driver and this puts the full review load on the maintainers.

We end up with crap like:

https://lore.kernel.org/lkml/9bbcce19c777583815c92ce3c2ff2586@www.loen.fr/

What is the end goal here ?

platform_get_resource and devm_ioremap_resource will have to stay even
after you have done the conversion.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com