linux-kernel - [PATCH v2 2/3] tty: serial: lpuart: Use defines that correspond to correct register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Oct 2019 14:14:40 +0000
From:   Philippe Schenker <philippe.schenker@...adex.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>
CC:     Max Krummenacher <max.krummenacher@...adex.com>,
        Jiri Slaby <jslaby@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Fugang Duan <fugang.duan@....com>,
        Stefan Agner <stefan@...er.ch>,
        "linux-imx@....com" <linux-imx@....com>,
        Andrey Smirnov <andrew.smirnov@...il.com>,
        Philippe Schenker <philippe.schenker@...adex.com>,
        Stefan Agner <stefan.agner@...adex.com>
Subject: [PATCH v2 2/3] tty: serial: lpuart: Use defines that correspond to
 correct register

Use define from the 32-bit register description UARTMODIR_* instead of
UARTMODEM_*. The value is the same, so there is no functional change.

Signed-off-by: Philippe Schenker <philippe.schenker@...adex.com>
Reviewed-by: Stefan Agner <stefan.agner@...adex.com>
Reviewed-by: Fugang Duan <fugang.duan@....com>

---

Changes in v2:
- Changed commit message to Stefans suggestions
- Added Stefan's and Fugang's reviewed tag

 drivers/tty/serial/fsl_lpuart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index f3271857621c..346b4a070ce9 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1879,10 +1879,10 @@ lpuart32_set_termios(struct uart_port *port, struct ktermios *termios,
 	}
 
 	if (termios->c_cflag & CRTSCTS) {
-		modem |= UARTMODEM_RXRTSE | UARTMODEM_TXCTSE;
+		modem |= (UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);
 	} else {
 		termios->c_cflag &= ~CRTSCTS;
-		modem &= ~(UARTMODEM_RXRTSE | UARTMODEM_TXCTSE);
+		modem &= ~(UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);
 	}
 
 	if (termios->c_cflag & CSTOPB)
-- 
2.23.0