linux-kernel - Re: [PATCH] scripts : mksysmap : NM variable missed the value,so fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <265d9be5-217d-3f67-ba94-095efdcf5787@infradead.org>
Date:   Thu, 17 Oct 2019 08:48:04 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Bhaskar Chowdhury <unixbhaskar@...il.com>,
        yamada.masahiro@...ionext.com, michal.lkml@...kovi.net
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org
Subject: Re: [PATCH] scripts : mksysmap : NM variable missed the value,so
 fixed

On 10/17/19 3:25 AM, Bhaskar Chowdhury wrote:
> This patch will provide the missing value for NM variable.
> 

Hi,

Does this patch fix some build error that you have encountered?
If so, please describe it and how to cause it.


> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>
> ---
> TO all,
> Adjusted the subject line, missed in previous one,sorry
> 
>  scripts/mksysmap | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/mksysmap b/scripts/mksysmap
> index a35acc0d0b82..4b2f45c45f14 100755
> --- a/scripts/mksysmap
> +++ b/scripts/mksysmap
> @@ -40,5 +40,5 @@
>  # 'W' or 'w'. __crc_ are 'A' and placed in the middle
>  # so we just ignore them to let readprofile continue to work.
>  # (At least sparc64 has __crc_ in the middle).
> -
> +NM=$(which nm)

That's not the POSIX way to do that.  It should be

NM=$(command -v nm)

But why is this needed at all?
The top-level Makefile exports the NM variable (and many more) to scripts
that it calls.

>  $NM -n $1 | grep -v '\( [aNUw] \)\|\(__crc_\)\|\( \$[adt]\)\|\( .L\)' > $2
> --
> 2.21.0
> 


-- 
~Randy