linux-kernel - Re: [PATCH v2] clk/ti/adpll: allocate room for terminating null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Oct 2019 08:48:53 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Michael Turquette <mturquette@...libre.com>,
        Stephen Kitt <steve@....org>, Tero Kristo <t-kristo@...com>,
        Tony Lindgren <tony@...mide.com>, linux-clk@...r.kernel.org,
        linux-omap@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Stephen Kitt <steve@....org>
Subject: Re: [PATCH v2] clk/ti/adpll: allocate room for terminating null

Quoting Stephen Kitt (2019-09-27 11:05:59)
> The buffer allocated in ti_adpll_clk_get_name doesn't account for the
> terminating null. This patch switches to ka_sprintf to avoid
> overflowing.
> 
> Signed-off-by: Stephen Kitt <steve@....org>
> ---
>  drivers/clk/ti/adpll.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
> index fdfb90058504..021cf9e2b4db 100644
> --- a/drivers/clk/ti/adpll.c
> +++ b/drivers/clk/ti/adpll.c
> @@ -195,14 +195,8 @@ static const char *ti_adpll_clk_get_name(struct ti_adpll_data *d,
>                         return NULL;
>         } else {
>                 const char *base_name = "adpll";

This is used once.

> -               char *buf;
> -
> -               buf = devm_kzalloc(d->dev, 8 + 1 + strlen(base_name) + 1 +
> -                                   strlen(postfix), GFP_KERNEL);
> -               if (!buf)
> -                       return NULL;
> -               sprintf(buf, "%08lx.%s.%s", d->pa, base_name, postfix);
> -               name = buf;
> +               name = devm_kasprintf(d->dev, GFP_KERNEL, "%08lx.%s.%s",

So why not make this "%08lx.adpll.%s"?

> +                                     d->pa, base_name, postfix);
>         }