linux-kernel - Re: [PATCH] coccinelle: api/devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e895d04ef5a282b5b48fcb21cbc175d2@www.loen.fr>
Date:   Thu, 17 Oct 2019 17:13:47 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Julia Lawall <julia.lawall@...6.fr>,
        Himanshu Jha <himanshujha199640@...il.com>,
        Linus Torvalds <torvalds@...uxfoundation.org>,
        <kernel-janitors@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>,
        <tglx@...utronix.de>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script

On 2019-10-17 15:22, Alexandre Belloni wrote:
> While it is useful for new drivers to use 
> devm_platform_ioremap_resource,
> this script is currently used to spam maintainers, often updating 
> very old
> drivers. The net benefit is the removal of 2 lines of code in the 
> driver
> but the review load for the maintainers is huge. As of now, more that 
> 560
> patches have been sent, some of them obviously broken, as in:
>
> 
> https://lore.kernel.org/lkml/9bbcce19c777583815c92ce3c2ff2586@www.loen.fr/
>
> Remove the script to reduce the spam.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

I think part of the issue is that the script reports a WARNING for 
something
that is definitely correct code, and could instead be simply toned 
down.

Anyway, FWIW:

Acked-by: Marc Zyngier <maz@...nel.org>

         M.
-- 
Jazz is not dead. It just smells funny...