linux-kernel - RE: [PATCH -next] crypto: inside-secure: fix build error for safexcel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 17 Oct 2019 16:16:36 +0000
From:   Pascal Van Leeuwen <pvanleeuwen@...imatrix.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>
CC:     Antoine Tenart <antoine.tenart@...e-electrons.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        David Miller <davem@...emloft.net>
Subject: RE: [PATCH -next] crypto: inside-secure: fix build error for
 safexcel_hash.c

> -----Original Message-----
> From: linux-crypto-owner@...r.kernel.org <linux-crypto-owner@...r.kernel.org> On Behalf Of
> Randy Dunlap
> Sent: Wednesday, October 9, 2019 5:50 PM
> To: LKML <linux-kernel@...r.kernel.org>; Linux Crypto Mailing List <linux-
> crypto@...r.kernel.org>
> Cc: Antoine Tenart <antoine.tenart@...e-electrons.com>; Herbert Xu
> <herbert@...dor.apana.org.au>; David Miller <davem@...emloft.net>
> Subject: [PATCH -next] crypto: inside-secure: fix build error for safexcel_hash.c
> 
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> safexcel_hash.c (CRYPTO_DEV_SAFEXCEL) needs to select CRYPTO_SM3.
> 
> Fixes this build error:
> 
> safexcel_hash.c:(.text+0x1b17): undefined reference to `sm3_zero_message_hash'
> 
> Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Antoine Tenart <antoine.tenart@...e-electrons.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: linux-crypto@...r.kernel.org
> ---
>  drivers/crypto/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20191009.orig/drivers/crypto/Kconfig
> +++ linux-next-20191009/drivers/crypto/Kconfig
> @@ -751,6 +751,7 @@ config CRYPTO_DEV_SAFEXCEL
>  	select CRYPTO_SHA512
>  	select CRYPTO_CHACHA20POLY1305
>  	select CRYPTO_SHA3
> +	select CRYPTO_SM3
>  	help
>  	  This driver interfaces with the SafeXcel EIP-97 and EIP-197 cryptographic
>  	  engines designed by Inside Secure. It currently accelerates DES, 3DES and
> 

I'm spinning a patch to fix this without having to
actually build in the SM3 module. So NACK on this patch.

Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com