linux-kernel - Re: [PATCH 08/20] riscv: abstract out CSR names for supervisor vs machine mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191017162052.GA10221@lst.de>
Date:   Thu, 17 Oct 2019 18:20:52 +0200
From:   Christoph Hellwig <hch@....de>
To:     Paul Walmsley <paul.walmsley@...ive.com>
Cc:     Christoph Hellwig <hch@....de>, Palmer Dabbelt <palmer@...ive.com>,
        Damien Le Moal <damien.lemoal@....com>,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Atish Patra <atish.patra@....com>
Subject: Re: [PATCH 08/20] riscv: abstract out CSR names for supervisor vs
 machine mode

On Tue, Oct 15, 2019 at 07:07:17PM -0700, Paul Walmsley wrote:
> >  void start_thread(struct pt_regs *regs, unsigned long pc,
> >  	unsigned long sp)
> >  {
> > -	regs->sstatus = SR_SPIE;
> > +	regs->xstatus = SR_SPIE;
> 
> Looks like this should be "regs->xstatus = SR_PIE;"
> 
> Will update it here.  Let me know if you don't agree -

there is no SR_PIE, do you mean SR_XPІE?  Good catch in that case,
but please let me resend the whole thing.  I have some minor updates,
and I'd also like to do the rebase myself.