linux-kernel - Re: KASAN: use-after-free Read in mnt_warn_timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191017025041.GC1552@sol.localdomain>
Date:   Wed, 16 Oct 2019 19:50:41 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     syzbot <syzbot+76a43f2b4d34cfc53548@...kaller.appspotmail.com>,
        akpm@...l.org, deepa.kernel@...il.com, hch@...radead.org,
        jlayton@...nel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, lkundrak@...sk,
        syzkaller-bugs@...glegroups.com, tklauser@...rscht.ch,
        trond.myklebust@....uio.no
Subject: Re: KASAN: use-after-free Read in mnt_warn_timestamp_expiry

On Thu, Oct 17, 2019 at 03:37:35AM +0100, Al Viro wrote:
> On Wed, Oct 16, 2019 at 07:27:05PM -0700, Eric Biggers wrote:
> 
> > How about the following?
> > 
> > 	pr_warn("%s filesystem being %s at %s supports timestamps until %04ld (0x%llx)\n",
> > 		sb->s_type->name,
> > 		is_mounted(mnt) ? "remounted" : "mounted",
> > 		mntpath,
> > 		tm.tm_year+1900, (unsigned long long)sb->s_time_max);
> > 
> > I think more people would understand "remounted" than "reconfigured".  Also,
> > is_mounted(mnt) seems like a better choice than mnt_has_parent(real_mount(mnt)).
> 
> Works for me(tm).  Care to fold that into your patch and resend?
> 

Sent: https://lkml.kernel.org/linux-fsdevel/20191017024814.61980-1-ebiggers@kernel.org/T/#u