linux-kernel - RE: [PATCH] crypto: inside-secure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MN2PR20MB297372195F99452234B9E48ECA6D0@MN2PR20MB2973.namprd20.prod.outlook.com>
Date:   Thu, 17 Oct 2019 16:53:04 +0000
From:   Pascal Van Leeuwen <pvanleeuwen@...imatrix.com>
To:     "Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk>,
        "linux-kernel@...ts.codethink.co.uk" 
        <linux-kernel@...ts.codethink.co.uk>
CC:     Antoine Tenart <antoine.tenart@...tlin.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] crypto: inside-secure - fix unexported warnings


> -----Original Message-----
> From: linux-crypto-owner@...r.kernel.org <linux-crypto-owner@...r.kernel.org> On Behalf Of Ben
> Dooks (Codethink)
> Sent: Wednesday, October 16, 2019 1:45 PM
> To: linux-kernel@...ts.codethink.co.uk
> Cc: Ben Dooks (Codethink) <ben.dooks@...ethink.co.uk>; Antoine Tenart
> <antoine.tenart@...tlin.com>; Herbert Xu <herbert@...dor.apana.org.au>; David S. Miller
> <davem@...emloft.net>; linux-crypto@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] crypto: inside-secure - fix unexported warnings
> 
> The safexcel_pci_remove, pcireg_rc and ofreg_rc are
> not exported or declared externally so make them static.
> 
> This avoids the following sparse warnings:
> 
> drivers/crypto/inside-secure/safexcel.c:1760:6: warning: symbol 'safexcel_pci_remove' was not
> declared. Should it be static?
> drivers/crypto/inside-secure/safexcel.c:1794:5: warning: symbol 'pcireg_rc' was not declared.
> Should it be static?
> drivers/crypto/inside-secure/safexcel.c:1797:5: warning: symbol 'ofreg_rc' was not declared.
> Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> ---
> Cc: Antoine Tenart <antoine.tenart@...tlin.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: linux-crypto@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/crypto/inside-secure/safexcel.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
> index 4ab1bde8dd9b..223d1bfdc7e6 100644
> --- a/drivers/crypto/inside-secure/safexcel.c
> +++ b/drivers/crypto/inside-secure/safexcel.c
> @@ -1757,7 +1757,7 @@ static int safexcel_pci_probe(struct pci_dev *pdev,
>  	return rc;
>  }
> 
> -void safexcel_pci_remove(struct pci_dev *pdev)
> +static void safexcel_pci_remove(struct pci_dev *pdev)
>  {
>  	struct safexcel_crypto_priv *priv = pci_get_drvdata(pdev);
>  	int i;
> @@ -1791,10 +1791,10 @@ static struct pci_driver safexcel_pci_driver = {
> 
>  /* Unfortunately, we have to resort to global variables here */
>  #if IS_ENABLED(CONFIG_PCI)
> -int pcireg_rc = -EINVAL; /* Default safe value */
> +static int pcireg_rc = -EINVAL; /* Default safe value */
>  #endif
>  #if IS_ENABLED(CONFIG_OF)
> -int ofreg_rc = -EINVAL; /* Default safe value */
> +static int ofreg_rc = -EINVAL; /* Default safe value */
>  #endif
> 
>  static int __init safexcel_init(void)
> --
> 2.23.0

Actually those variables have already disappeared from the 
cryptodev tree due to an earlier patch by Arnd.
So this patch won't apply anyway.

I'll see if I can spin a patch that makes safexcel_pci_remove
static.

Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com