linux-kernel - Re: [PATCH 4.19 62/81] cifs: use cifsInodeInfo->open_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191017171953.GV31224@sasha-vm>
Date:   Thu, 17 Oct 2019 13:19:53 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Pavel Machek <pavel@...x.de>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Dave Wysochanski <dwysocha@...hat.com>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        Steve French <stfrench@...rosoft.com>
Subject: Re: [PATCH 4.19 62/81] cifs: use cifsInodeInfo->open_file_lock while
 iterating to avoid a panic

On Thu, Oct 17, 2019 at 09:01:17AM -0700, Greg Kroah-Hartman wrote:
>On Thu, Oct 17, 2019 at 10:55:39AM +0200, Pavel Machek wrote:
>> Hi!
>>
>> > From: Dave Wysochanski <dwysocha@...hat.com>
>> >
>> > Commit 487317c99477 ("cifs: add spinlock for the openFileList to
>> > cifsInodeInfo") added cifsInodeInfo->open_file_lock spin_lock to protect
>>
>> > Fixes: 487317c99477 ("cifs: add spinlock for the openFileList to cifsInodeInfo")
>> >
>> > CC: Stable <stable@...r.kernel.org>
>> > Signed-off-by: Dave Wysochanski <dwysocha@...hat.com>
>> > Reviewed-by: Ronnie Sahlberg <lsahlber@...hat.com>
>> > Signed-off-by: Steve French <stfrench@...rosoft.com>
>>
>> This is missing upstream commit ID and a signoff.
>
>Good catch, Sasha forgot to do that :(

I was actually thinking I'll need to replace it with David's patch. Let
me look into it.

-- 
Thanks,
Sasha