linux-kernel - Re: [PATCH] libfdt: reduce the number of headers included from libfdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57c33deb-651b-3357-0e5a-95379be8a965@gmail.com>
Date:   Thu, 17 Oct 2019 12:23:37 -0500
From:   Frank Rowand <frowand.list@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        DTML <devicetree@...r.kernel.org>
Subject: Re: [PATCH] libfdt: reduce the number of headers included from
 libfdt_env.h

On 10/16/2019 06:01, Masahiro Yamada wrote:
> Hi Andrew,
> 
> Could you pick up this to akpm tree?
> https://lore.kernel.org/patchwork/patch/1089856/
> 
> I believe this is correct, and a good clean-up.
> 
> I pinged the DT maintainers, but they did not respond.

Sorry for the delay in responding.

libfdt_env.h is imported from an upstream project, using
the script scripts/dtc/update-dtc-source.sh.  Inside
that script are some 'sed' commands to modify the
imported files before committing them.  Please add
a sed command to make the change that the proposed
patch makes.

Thanks,

Frank

> 
> Thanks.
> 
> 
> 
> 
> On Mon, Aug 19, 2019 at 1:36 PM Masahiro Yamada
> <yamada.masahiro@...ionext.com> wrote:
>>
>> On Thu, Aug 1, 2019 at 11:30 AM Masahiro Yamada
>> <yamada.masahiro@...ionext.com> wrote:
>>>
>>> On Tue, Jun 18, 2019 at 1:21 AM Masahiro Yamada
>>> <yamada.masahiro@...ionext.com> wrote:
>>>>
>>>> Currently, libfdt_env.h includes <linux/kernel.h> just for INT_MAX.
>>>>
>>>> <linux/kernel.h> pulls in a lots of broat.
>>>>
>>>> Thanks to commit 54d50897d544 ("linux/kernel.h: split *_MAX and *_MIN
>>>> macros into <linux/limits.h>"), <linux/kernel.h> can be replaced with
>>>> <linux/limits.h>.
>>>>
>>>> This saves including dozens of headers.
>>>>
>>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>>>> ---
>>>
>>> ping?
>>
>> ping x2.
>>
>>
>>
>>
>>>
>>>
>>>>  include/linux/libfdt_env.h | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/linux/libfdt_env.h b/include/linux/libfdt_env.h
>>>> index edb0f0c30904..2231eb855e8f 100644
>>>> --- a/include/linux/libfdt_env.h
>>>> +++ b/include/linux/libfdt_env.h
>>>> @@ -2,7 +2,7 @@
>>>>  #ifndef LIBFDT_ENV_H
>>>>  #define LIBFDT_ENV_H
>>>>
>>>> -#include <linux/kernel.h>      /* For INT_MAX */
>>>> +#include <linux/limits.h>      /* For INT_MAX */
>>>>  #include <linux/string.h>
>>>>
>>>>  #include <asm/byteorder.h>
>>>> --
>>>> 2.17.1
>>>>
>>>
>>>
>>> --
>>> Best Regards
>>> Masahiro Yamada
>>
>>
>>
>> --
>> Best Regards
>> Masahiro Yamada
> 
> 
>