linux-kernel - Re: [PATCH v2 1/5] proc/meminfo: fix output alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHbLzkqL4iUVF5d01uBU8HhT7U3jq4urdNZNCE3pK2QfySSYHw@mail.gmail.com>
Date:   Thu, 17 Oct 2019 10:37:40 -0700
From:   Yang Shi <shy828301@...il.com>
To:     Song Liu <songliubraving@...com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux MM <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        matthew.wilcox@...cle.com, kernel-team@...com,
        william.kucharski@...cle.com,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Subject: Re: [PATCH v2 1/5] proc/meminfo: fix output alignment

On Thu, Oct 17, 2019 at 9:42 AM Song Liu <songliubraving@...com> wrote:
>
> From: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
>
> Add extra space for FileHugePages and FilePmdMapped, so the output is
> aligned with other rows.
>
> Fixes: 60fbf0ab5da1 ("mm,thp: stats for file backed THP")
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> Tested-by: Song Liu <songliubraving@...com>
> Signed-off-by: Song Liu <songliubraving@...com>

Acked-by: Yang Shi <yang.shi@...ux.alibaba.com>

> ---
>  fs/proc/meminfo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c
> index ac9247371871..8c1f1bb1a5ce 100644
> --- a/fs/proc/meminfo.c
> +++ b/fs/proc/meminfo.c
> @@ -132,9 +132,9 @@ static int meminfo_proc_show(struct seq_file *m, void *v)
>                     global_node_page_state(NR_SHMEM_THPS) * HPAGE_PMD_NR);
>         show_val_kb(m, "ShmemPmdMapped: ",
>                     global_node_page_state(NR_SHMEM_PMDMAPPED) * HPAGE_PMD_NR);
> -       show_val_kb(m, "FileHugePages: ",
> +       show_val_kb(m, "FileHugePages:  ",
>                     global_node_page_state(NR_FILE_THPS) * HPAGE_PMD_NR);
> -       show_val_kb(m, "FilePmdMapped: ",
> +       show_val_kb(m, "FilePmdMapped:  ",
>                     global_node_page_state(NR_FILE_PMDMAPPED) * HPAGE_PMD_NR);
>  #endif
>
> --
> 2.17.1
>
>