linux-kernel - Re: [PATCH 1/2] input: edt-ft5x06

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191017180323.GJ35946@dtor-ws>
Date:   Thu, 17 Oct 2019 11:03:23 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Cc:     linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH 1/2] input: edt-ft5x06 - add polled input support

Hi Nicolas,

On Wed, Jun 12, 2019 at 01:57:46PM +0200, Nicolas Saenz Julienne wrote:
> On Tue, 2019-04-30 at 20:58 +0200, Nicolas Saenz Julienne wrote:
> > Some hardware configurations might pass on providing an interrupt line.
> > In that case there is always the option to use a polled input approach.
> > This patch adapts the driver for it.
> > 
> > The polled approach is only triggered if no interrupt is provided by the
> > firmware or platform data.
> > 
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
> > ---
> 
> Ping :)

I reworked the polling in input devices so we no longer need to create a
separate input_polled_dev instances and instead have regular input
device work in polled mode by calling

	error = input_setup_polling(input_dev, poll_fn);
	...

Please adjust your patch and resubmit.

Thanks.

-- 
Dmitry