linux-kernel - Re: [PATCH v3] tpm/tpm_ftpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191017180644.GW31224@sasha-vm>
Date:   Thu, 17 Oct 2019 14:06:44 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     Pavel Tatashin <pasha.tatashin@...een.com>, jmorris@...ei.org,
        peterhuewe@....de, jgg@...pe.ca, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-integrity@...r.kernel.org,
        linux-kernel@...rosoft.com, thiruan@...rosoft.com,
        bryankel@...rosoft.com, tee-dev@...ts.linaro.org,
        ilias.apalodimas@...aro.org, sumit.garg@...aro.org,
        rdunlap@...radead.org
Subject: Re: [PATCH v3] tpm/tpm_ftpm_tee: add shutdown call back

On Thu, Oct 17, 2019 at 07:22:51PM +0300, Jarkko Sakkinen wrote:
>On Wed, Oct 16, 2019 at 12:31:14PM -0400, Pavel Tatashin wrote:
>> Add shutdown call back to close existing session with fTPM TA
>> to support kexec scenario.
>>
>> Add parentheses to function names in comments as specified in kdoc.
>>
>> Signed-off-by: Thirupathaiah Annapureddy <thiruan@...rosoft.com>
>> Signed-off-by: Pavel Tatashin <pasha.tatashin@...een.com>
>
>LGTM
>
>Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
>
>I have no means to test this though. It still needs a tested-by.

We've been running this patch internally for the past few months,
testing kexec scenarios, so I guess it could have mine :)

Tested-by: Sasha Levin <sashal@...nel.org>

-- 
Thanks,
Sasha