linux-kernel - Re: [PATCH v12 07/22] riscv: mm: Add p?d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe6a0fe4-e789-fb4b-4481-b3934234e16f@arm.com>
Date:   Fri, 18 Oct 2019 17:20:30 +0100
From:   Steven Price <steven.price@....com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Mark Rutland <Mark.Rutland@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Dave Hansen <dave.hansen@...ux.intel.com>, linux-mm@...ck.org,
        Albert Ou <aou@...s.berkeley.edu>,
        "H. Peter Anvin" <hpa@...or.com>, linux-riscv@...ts.infradead.org,
        Will Deacon <will@...nel.org>,
        "Liang, Kan" <kan.liang@...ux.intel.com>,
        Alexandre Ghiti <alex@...ti.fr>, x86@...nel.org,
        Ingo Molnar <mingo@...hat.com>,
        Palmer Dabbelt <palmer@...ive.com>,
        Arnd Bergmann <arnd@...db.de>,
        Jérôme Glisse <jglisse@...hat.com>,
        Borislav Petkov <bp@...en8.de>,
        Andy Lutomirski <luto@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-arm-kernel@...ts.infradead.org,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        linux-kernel@...r.kernel.org, James Morse <james.morse@....com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v12 07/22] riscv: mm: Add p?d_leaf() definitions

On 18/10/2019 16:57, Christoph Hellwig wrote:
>> +	return pud_present(pud)
>> +		&& (pud_val(pud) & (_PAGE_READ | _PAGE_WRITE | _PAGE_EXEC));
>> +}
> 
> The operators always need to go before the line break, not after it
> per linux coding style.  There are a few more spots like this, so please
> audit the whole series for it.

Fair enough. In this case I was just copying the example in pte_huge()
that already existed - but you're right this isn't the kernel coding style.

Thanks,

Steve