linux-kernel - clk: bcm2835: Checking a clk_register() call in bcm2835_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 18 Oct 2019 20:42:27 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     linux-clk@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        bcm-kernel-feedback-list@...adcom.com,
        Eric Anholt <eric@...olt.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Matthias Brugger <mbrugger@...e.com>,
        Maxime Ripard <mripard@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Scott Branden <sbranden@...adcom.com>,
        Stefan Wahren <wahrenst@....net>,
        Stephen Boyd <sboyd@...nel.org>, Ray Jui <rjui@...adcom.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, Aditya Pakki <pakki001@....edu>,
        Kangjie Lu <kjlu@....edu>, Navid Emamdoost <emamd001@....edu>,
        Stephen McCamant <smccaman@....edu>
Subject: clk: bcm2835: Checking a clk_register() call in bcm2835_clk_probe()

Hello,

I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “bcm2835_clk_probe” contains still
an unchecked call of the member function “clk_register”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/bcm/clk-bcm2835.c?id=7571438a4868e7cb09d698ab52e54f9722020eef#n2243
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/clk/bcm/clk-bcm2835.c#L2243

How do you think about to improve it?

* Which error code would you like to return for a failed
  clock registration at this place?

* Will it be needed to delete any information about clocks
  as exception handling?

Regards,
Markus