linux-kernel - Re: [PATCH v2 31/33] tools lib bpf: Renaming pr_warning to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Oct 2019 20:52:20 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        linux-kernel@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        bpf@...r.kernel.org, Andrii Nakryiko <andriin@...com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH v2 31/33] tools lib bpf: Renaming pr_warning to pr_warn

On Fri, Oct 18, 2019 at 09:04:57AM +0200, Petr Mladek wrote:
> On Thu 2019-10-17 21:24:19, Alexei Starovoitov wrote:
> > On Fri, Oct 18, 2019 at 11:18:48AM +0800, Kefeng Wang wrote:
> > > For kernel logging macro, pr_warning is completely removed and
> > > replaced by pr_warn, using pr_warn in tools lib bpf for symmetry
> > > to kernel logging macro, then we could drop pr_warning in the
> > > whole linux code.
> > > 
> > > Cc: Alexei Starovoitov <ast@...nel.org>
> > > Cc: Daniel Borkmann <daniel@...earbox.net>
> > > Cc: Martin KaFai Lau <kafai@...com>
> > > Cc: Song Liu <songliubraving@...com>
> > > Cc: Yonghong Song <yhs@...com>
> > > Cc: bpf@...r.kernel.org
> > > Acked-by: Andrii Nakryiko <andriin@...com>
> > > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> > > Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> > > ---
> > >  tools/lib/bpf/btf.c             |  56 +--
> > >  tools/lib/bpf/btf_dump.c        |  18 +-
> > >  tools/lib/bpf/libbpf.c          | 679 ++++++++++++++++----------------
> > >  tools/lib/bpf/libbpf_internal.h |   8 +-
> > >  tools/lib/bpf/xsk.c             |   4 +-
> > >  5 files changed, 379 insertions(+), 386 deletions(-)
> > 
> > Nack.
> > I prefer this type of renaming to go via bpf tree.
> > It's not a kernel patch. It's touching user space library
> > which is under heavy development.
> > Doing any other way will cause a ton of conflicts.
> 
> Fair enough. I'll ignore this patch. Could I assume that it will
> be taken via bpf tree, please?
> 
> I'll also postpone the patch that removes pr_warning() to avoid
> synchronization problems. I'll push it later when changes in
> bpf[*] subsystem are merged.
> 
> [*] I am going to check conflicts against 5.4-rc1. I'll probably
> ask more subsystems to take their changes to avoid conflicts
> and make it smooth.

The stand-alone patch as-is currently doesn't apply to bpf-next.
Could you spin a fresh rebase and resubmit?

Thanks,
Daniel