linux-kernel - Re: [tip: x86/asm] x86/asm/ftrace: Mark function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191018194856.GC20368@zn.tnic>
Date:   Fri, 18 Oct 2019 21:48:56 +0200
From:   Borislav Petkov <bp@...e.de>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     tip-bot2 for Jiri Slaby <tip-bot2@...utronix.de>,
        linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org,
        Jiri Slaby <jslaby@...e.cz>, "H. Peter Anvin" <hpa@...or.com>,
        Ingo Molnar <mingo@...hat.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        linux-arch@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>, x86-ml <x86@...nel.org>,
        Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>
Subject: Re: [tip: x86/asm] x86/asm/ftrace: Mark function_hook as function

On Fri, Oct 18, 2019 at 01:37:35PM -0400, Steven Rostedt wrote:
> It just needs to be visible by modules and what not, otherwise linking
> will fail.

And I assume all of them?

> The #define was because we use to support mcount or __fentry__, now we
> just support __fentry__, and function_hook describes it better ;-)

Well sorry but gcc documentation talks about __fentry__. I'd keep the
same name to avoid confusion and explain above it what it is. Much
better.

> Heh, I guess we could, which would probably be quite a long comment as
> it's the key behind ftrace itself.

Well, you can explain with a couple of sentences what it is and
then point at the bigger document explaining ftrace. Provided, Mr.
Rostedt, you'll stop doing talks and finally sit down and write that
documentation!

:-P

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg