linux-kernel - Re: [PATCH 1/3] auxdisplay: Make charlcd.[ch] more general

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191018215552.GX9933@tassilo.jf.intel.com>
Date:   Fri, 18 Oct 2019 14:55:52 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        Lars Poeschel <poeschel@...onage.de>,
        Vadim Bendebury <vbendeb@...omium.org>,
        Willy Tarreau <willy@...roxy.com>,
        Ksenija Stanojevic <ksenija.stanojevic@...il.com>,
        open list <linux-kernel@...r.kernel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH 1/3] auxdisplay: Make charlcd.[ch] more general

On Fri, Oct 18, 2019 at 08:33:26AM -0700, Joe Perches wrote:
> On Fri, 2019-10-18 at 17:08 +0200, Miguel Ojeda wrote:
> > On Thu, Oct 17, 2019 at 10:07 AM Lars Poeschel <poeschel@...onage.de> wrote:
> []
> > > Oh by the way: Do you know what I can do to make checkpatch happy with
> > > its describing of the config symbol ? I tried writing a help paragraph
> > > for the config symbols in Kconfig, but that did not help.
> > 
> > CC'ing Joe.
> 
> add
> 	--ignore=CONFIG_DESCRIPTION
> or
> 	--min-conf-desc-length=1 (default is 4)
> 
> to the checkpatch command line, or just ignore it.
> 
> AK: I guess there's still some debate as to the proper
> minimum length of a Kconfig help section paragraph.

I still think four lines is a good minimum

If it's not worth writing 4 lines for, perhaps the Kconfig
symbol is not needed at all?

-Andi