linux-kernel - Re: [PATCH v3 1/3] kasan: Archs don't check memmove if not support it.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.9999.1910171957310.3156@viisi.sifive.com>
Date:   Thu, 17 Oct 2019 19:58:04 -0700 (PDT)
From:   Paul Walmsley <paul.walmsley@...ive.com>
To:     Nick Hu <nickhu@...estech.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>
cc:     alankao@...estech.com, palmer@...ive.com, aou@...s.berkeley.edu,
        glider@...gle.com, dvyukov@...gle.com, corbet@....net,
        alexios.zavras@...el.com, allison@...utok.net, Anup.Patel@....com,
        tglx@...utronix.de, gregkh@...uxfoundation.org,
        atish.patra@....com, kstewart@...uxfoundation.org,
        linux-doc@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, kasan-dev@...glegroups.com,
        linux-mm@...ck.org
Subject: Re: [PATCH v3 1/3] kasan: Archs don't check memmove if not support
 it.

On Thu, 17 Oct 2019, Andrey Ryabinin wrote:

> On 10/8/19 9:11 AM, Nick Hu wrote:
> > Skip the memmove checking for those archs who don't support it.
>  
> The patch is fine but the changelog sounds misleading. We don't skip memmove checking.
> If arch don't have memmove than the C implementation from lib/string.c used.
> It's instrumented by compiler so it's checked and we simply don't need that KASAN's memmove with
> manual checks.

Thanks Andrey.  Nick, could you please update the patch description?

- Paul