linux-kernel - Re: [PATCH] opp: core: Revert "add regulators enable and disable"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db377033-3d1d-f8c7-b0c0-5a7359022a62@samsung.com>
Date:   Fri, 18 Oct 2019 09:11:56 +0200
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     linux-pm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Viresh Kumar <vireshk@...nel.org>,
        Nishanth Menon <nm@...com>, Stephen Boyd <sboyd@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        Dmitry Osipenko <digetx@...il.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Kamil Konieczny <k.konieczny@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH] opp: core: Revert "add regulators enable and disable"


On 18.10.2019 06:30, Viresh Kumar wrote:
> On 17-10-19, 12:27, Marek Szyprowski wrote:
>> All the drivers, which use the OPP framework control regulators, which
>> are already enabled. Typically those regulators are also system critical,
>> due to providing power to CPU core or system buses. It turned out that
>> there are cases, where calling regulator_enable() on such boot-enabled
>> regulator has side-effects and might change its initial voltage due to
>> performing initial voltage balancing without all restrictions from the
>> consumers. Until this issue becomes finally solved in regulator core,
>> avoid calling regulator_enable()/disable() from the OPP framework.
>>
>> This reverts commit 7f93ff73f7c8c8bfa6be33bcc16470b0b44682aa.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
>> ---
>> This is a follow-up from the following discussion:
>> https://lkml.org/lkml/2019/10/9/541
> I suppose this must go the v5.4-rcs, right ?

Yes, please.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland