linux-kernel - Re: [PATCH v9 24/28] x86_64/asm: Change all ENTRY+ENDPROC to SYM_FUNC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191018065623.GA15199@gondor.apana.org.au>
Date:   Fri, 18 Oct 2019 17:56:23 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Borislav Petkov <bp@...en8.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jiri Slaby <jslaby@...e.cz>, tglx@...utronix.de,
        mingo@...hat.com, hpa@...or.com, x86@...nel.org,
        linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        Matt Fleming <matt@...eblueprint.co.uk>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Juergen Gross <jgross@...e.com>, linux-crypto@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-efi@...r.kernel.org,
        xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v9 24/28] x86_64/asm: Change all ENTRY+ENDPROC to
 SYM_FUNC_*

On Wed, Oct 16, 2019 at 09:12:30AM +0200, Borislav Petkov wrote:
> Hi,
> 
> On Fri, Oct 11, 2019 at 01:51:04PM +0200, Jiri Slaby wrote:
> > These are all functions which are invoked from elsewhere, so annotate
> > them as global using the new SYM_FUNC_START. And their ENDPROC's by
> > SYM_FUNC_END.
> > 
> > And make sure ENTRY/ENDPROC is not defined on X86_64, given these were
> > the last users.
> > 
> > Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> > Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com> [hibernate]
> > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com> [xen bits]
> > Cc: "H. Peter Anvin" <hpa@...or.com>
> > Cc: Borislav Petkov <bp@...en8.de>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Ingo Molnar <mingo@...hat.com>
> > Cc: x86@...nel.org
> > Cc: Herbert Xu <herbert@...dor.apana.org.au>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> > Cc: Len Brown <len.brown@...el.com>
> > Cc: Pavel Machek <pavel@....cz>
> > Cc: Matt Fleming <matt@...eblueprint.co.uk>
> > Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> > Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> > Cc: Juergen Gross <jgross@...e.com>
> > Cc: linux-crypto@...r.kernel.org
> > Cc: linux-pm@...r.kernel.org
> > Cc: linux-efi@...r.kernel.org
> > Cc: xen-devel@...ts.xenproject.org
> > ---
> >  arch/x86/boot/compressed/efi_thunk_64.S      |  4 +-
> >  arch/x86/boot/compressed/head_64.S           | 16 +++---
> >  arch/x86/boot/compressed/mem_encrypt.S       |  8 +--
> >  arch/x86/crypto/aegis128-aesni-asm.S         | 28 ++++-----
> >  arch/x86/crypto/aes_ctrby8_avx-x86_64.S      | 12 ++--
> >  arch/x86/crypto/aesni-intel_asm.S            | 60 ++++++++++----------
> >  arch/x86/crypto/aesni-intel_avx-x86_64.S     | 32 +++++------
> >  arch/x86/crypto/blowfish-x86_64-asm_64.S     | 16 +++---
> >  arch/x86/crypto/camellia-aesni-avx-asm_64.S  | 24 ++++----
> >  arch/x86/crypto/camellia-aesni-avx2-asm_64.S | 24 ++++----
> >  arch/x86/crypto/camellia-x86_64-asm_64.S     | 16 +++---
> >  arch/x86/crypto/cast5-avx-x86_64-asm_64.S    | 16 +++---
> >  arch/x86/crypto/cast6-avx-x86_64-asm_64.S    | 24 ++++----
> >  arch/x86/crypto/chacha-avx2-x86_64.S         | 12 ++--
> >  arch/x86/crypto/chacha-avx512vl-x86_64.S     | 12 ++--
> >  arch/x86/crypto/chacha-ssse3-x86_64.S        | 12 ++--
> >  arch/x86/crypto/crc32-pclmul_asm.S           |  4 +-
> >  arch/x86/crypto/crc32c-pcl-intel-asm_64.S    |  4 +-
> >  arch/x86/crypto/crct10dif-pcl-asm_64.S       |  4 +-
> >  arch/x86/crypto/des3_ede-asm_64.S            |  8 +--
> >  arch/x86/crypto/ghash-clmulni-intel_asm.S    |  8 +--
> >  arch/x86/crypto/nh-avx2-x86_64.S             |  4 +-
> >  arch/x86/crypto/nh-sse2-x86_64.S             |  4 +-
> >  arch/x86/crypto/poly1305-avx2-x86_64.S       |  4 +-
> >  arch/x86/crypto/poly1305-sse2-x86_64.S       |  8 +--
> >  arch/x86/crypto/serpent-avx-x86_64-asm_64.S  | 24 ++++----
> >  arch/x86/crypto/serpent-avx2-asm_64.S        | 24 ++++----
> >  arch/x86/crypto/serpent-sse2-x86_64-asm_64.S |  8 +--
> >  arch/x86/crypto/sha1_avx2_x86_64_asm.S       |  4 +-
> >  arch/x86/crypto/sha1_ni_asm.S                |  4 +-
> >  arch/x86/crypto/sha1_ssse3_asm.S             |  4 +-
> >  arch/x86/crypto/sha256-avx-asm.S             |  4 +-
> >  arch/x86/crypto/sha256-avx2-asm.S            |  4 +-
> >  arch/x86/crypto/sha256-ssse3-asm.S           |  4 +-
> >  arch/x86/crypto/sha256_ni_asm.S              |  4 +-
> >  arch/x86/crypto/sha512-avx-asm.S             |  4 +-
> >  arch/x86/crypto/sha512-avx2-asm.S            |  4 +-
> >  arch/x86/crypto/sha512-ssse3-asm.S           |  4 +-
> >  arch/x86/crypto/twofish-avx-x86_64-asm_64.S  | 24 ++++----
> >  arch/x86/crypto/twofish-x86_64-asm_64-3way.S |  8 +--
> >  arch/x86/crypto/twofish-x86_64-asm_64.S      |  8 +--
> 
> I could use an ACK for the crypto bits...

Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt