linux-kernel - Re: [PATCH v2 19/33] platform/x86: asus-laptop: Use pr_warn instead of pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VesP5qfk3r2o-R+OuBE1DA0-24ZGNgmAaSkfPiUjFAQDQ@mail.gmail.com>
Date:   Fri, 18 Oct 2019 10:51:55 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     Petr Mladek <pmladek@...e.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Corentin Chary <corentin.chary@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH v2 19/33] platform/x86: asus-laptop: Use pr_warn instead
 of pr_warning

On Fri, Oct 18, 2019 at 6:19 AM Kefeng Wang <wangkefeng.wang@...wei.com> wrote:
>
> As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of
> pr_warning"), removing pr_warning so all logging messages use a
> consistent <prefix>_warn style. Let's do it.

Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Cc: Corentin Chary <corentin.chary@...il.com>
> Cc: Darren Hart <dvhart@...radead.org>
> Cc: Andy Shevchenko <andy@...radead.org>
> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---
>  drivers/platform/x86/asus-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index fc6446209854..a666fbc2e73b 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -1148,7 +1148,7 @@ static void asus_als_switch(struct asus_laptop *asus, int value)
>                 ret = write_acpi_int(asus->handle, METHOD_ALS_CONTROL, value);
>         }
>         if (ret)
> -               pr_warning("Error setting light sensor switch\n");
> +               pr_warn("Error setting light sensor switch\n");
>
>         asus->light_switch = value;
>  }
> --
> 2.20.1
>


-- 
With Best Regards,
Andy Shevchenko