linux-kernel - Re: [PATCH] crypto: hisilicon: Fix misuse of GENMASK macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191018080706.GO25128@gondor.apana.org.au>
Date:   Fri, 18 Oct 2019 19:07:06 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Rikard Falkeborn <rikard.falkeborn@...il.com>
Cc:     xuzaibo@...wei.com, davem@...emloft.net,
        forest.zhouchang@...wei.com, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        tanghui20@...wei.com
Subject: Re: [PATCH] crypto: hisilicon: Fix misuse of GENMASK macro

On Tue, Oct 15, 2019 at 10:13:30PM +0200, Rikard Falkeborn wrote:
> Arguments are supposed to be ordered high then low.
> 
> Fixes: c8b4b477079d ("crypto: hisilicon - add HiSilicon HPRE accelerator")
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com>
> ---
> Spotted when trying to introduce compile time checking that the order
> of the arguments to GENMASK are correct [0]. I have only compile tested
> the patch.
> 
> [0]: https://lore.kernel.org/lkml/20191009214502.637875-1-rikard.falkeborn@gmail.com/
> 
>  drivers/crypto/hisilicon/hpre/hpre_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt