linux-kernel - Re: [PATCH v4 16/16] ftrace: Merge ftrace_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191018082037.GF2328@hirez.programming.kicks-ass.net>
Date:   Fri, 18 Oct 2019 10:20:37 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     x86@...nel.org
Cc:     linux-kernel@...r.kernel.org, rostedt@...dmis.org,
        mhiramat@...nel.org, bristot@...hat.com, jbaron@...mai.com,
        torvalds@...ux-foundation.org, tglx@...utronix.de,
        mingo@...nel.org, namit@...are.com, hpa@...or.com, luto@...nel.org,
        ard.biesheuvel@...aro.org, jpoimboe@...hat.com, jeyu@...nel.org
Subject: Re: [PATCH v4 16/16] ftrace: Merge ftrace_module_{init,enable}()

On Fri, Oct 18, 2019 at 09:35:41AM +0200, Peter Zijlstra wrote:
> Because of how some architectures used set_all_modules_text_*() there
> was a dependency between the module state and its memory protection
> state. This then required ftrace to be split into two functions, see
> commit:
> 
>   a949ae560a51 ("ftrace/module: Hardcode ftrace_module_init() call into load_module()")
> 
> Now that set_all_modules_text_*() is dead and burried, this is no
> longer relevant and we can merge the ftrace_module hooks again.

NOTE that by also getting rid of the ftrace_arch_code_modify_prepare() /
ftrace_arch_code_modify_post_process() callbacks in the
ftrace_module_enable() callback, both x86 and ARM will use direct poking
instead of doing the alias thing.