linux-kernel - Re: [PATCH] drm/arm: make undeclared items static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191018094907.66ghzs3qiyelibzh@e110455-lin.cambridge.arm.com>
Date:   Fri, 18 Oct 2019 10:49:07 +0100
From:   Liviu Dudau <liviu.dudau@....com>
To:     "Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk>
Cc:     linux-kernel@...ts.codethink.co.uk,
        Brian Starkey <brian.starkey@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, malidp@...s.arm.com,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/arm: make undeclared items static

On Thu, Oct 17, 2019 at 12:17:55PM +0100, Ben Dooks (Codethink) wrote:
> Make the following items static to avoid clashes with
> other parts of the kernel (dev_attr_core_id) or just
> silence the following sparse warning:
> 
> drivers/gpu/drm/arm/malidp_drv.c:371:24: warning: symbol 'malidp_fb_create' was not declared. Should it be static?
> drivers/gpu/drm/arm/malidp_drv.c:494:6: warning: symbol 'malidp_error_stats_dump' was not declared. Should it be static?
> drivers/gpu/drm/arm/malidp_drv.c:668:1: warning: symbol 'dev_attr_core_id' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>

Acked-by: Liviu Dudau <liviu.dudau@....com>

Thanks for the patch! As a side note: the dim tool that we use in the DRM subsystem
flags your S-o-b as being different from author, due to "(Codethink)" addition in the
email name.

Best regards,
Liviu

> ---
> Cc: Liviu Dudau <liviu.dudau@....com>
> Cc: Brian Starkey <brian.starkey@....com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: malidp@...s.arm.com
> Cc: dri-devel@...ts.freedesktop.org
> Cc: linux-kernel@...r.kernel.org
> .. (open list)
> ---
>  drivers/gpu/drm/arm/malidp_drv.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> index 333b88a5efb0..18ca43c9cef4 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -368,7 +368,7 @@ malidp_verify_afbc_framebuffer(struct drm_device *dev, struct drm_file *file,
>  	return false;
>  }
>  
> -struct drm_framebuffer *
> +static struct drm_framebuffer *
>  malidp_fb_create(struct drm_device *dev, struct drm_file *file,
>  		 const struct drm_mode_fb_cmd2 *mode_cmd)
>  {
> @@ -491,9 +491,9 @@ void malidp_error(struct malidp_drm *malidp,
>  	spin_unlock_irqrestore(&malidp->errors_lock, irqflags);
>  }
>  
> -void malidp_error_stats_dump(const char *prefix,
> -			     struct malidp_error_stats error_stats,
> -			     struct seq_file *m)
> +static void malidp_error_stats_dump(const char *prefix,
> +				    struct malidp_error_stats error_stats,
> +				    struct seq_file *m)
>  {
>  	seq_printf(m, "[%s] num_errors : %d\n", prefix,
>  		   error_stats.num_errors);
> @@ -665,7 +665,7 @@ static ssize_t core_id_show(struct device *dev, struct device_attribute *attr,
>  	return snprintf(buf, PAGE_SIZE, "%08x\n", malidp->core_id);
>  }
>  
> -DEVICE_ATTR_RO(core_id);
> +static DEVICE_ATTR_RO(core_id);
>  
>  static int malidp_init_sysfs(struct device *dev)
>  {
> -- 
> 2.23.0
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯