linux-kernel - Re: [PATCH 0/2] PCI/PM: Use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2088720.TElhCYhjX6@kreacher>
Date:   Fri, 18 Oct 2019 12:26:20 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     linux-pci@...r.kernel.org,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 0/2] PCI/PM: Use dev_printk() when possible

On Thursday, October 17, 2019 11:28:49 PM CEST Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> Some PM messages, e.g., "PCI PM: Device state not saved by %pS\n", had no
> indication of what device was affected.  Add pci_WARN() and use it.
> 
> Bjorn Helgaas (2):
>   PCI/PM: Use PCI dev_printk() wrappers for consistency
>   PCI/PM: Use pci_WARN() to include device information
> 
>  drivers/pci/pci-driver.c | 45 ++++++++++++++++++++--------------------
>  include/linux/pci.h      |  8 +++++++
>  2 files changed, 31 insertions(+), 22 deletions(-)
> 
> 

Good cleanups!

For both

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>