linux-kernel - Re: [PATCH] mm,thp: recheck each page before collapsing file THP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191018142523.GL32665@bombadil.infradead.org>
Date:   Fri, 18 Oct 2019 07:25:23 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Song Liu <songliubraving@...com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        akpm@...ux-foundation.org, matthew.wilcox@...cle.com,
        kernel-team@...com, william.kucharski@...cle.com,
        kirill.shutemov@...ux.intel.com,
        Johannes Weiner <hannes@...xchg.org>,
        Hugh Dickins <hughd@...gle.com>
Subject: Re: [PATCH] mm,thp: recheck each page before collapsing file THP

On Thu, Oct 17, 2019 at 10:08:32PM -0700, Song Liu wrote:
> +			/* double check the page is correct and clean */
> +			if (unlikely(!PageUptodate(page)) ||
> +			    unlikely(PageDirty(page)) ||
> +			    unlikely(page->mapping != mapping)) {

That's kind of an ugly way of writing it.  Why not more simply:

			if (unlikely(!PageUptodate(page) || PageDirty(page) ||
				     page->mapping != mapping)) {