linux-kernel - Re: [PATCH v3 0/3] Logitech G920 fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 18 Oct 2019 16:51:54 +0200
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>
Cc:     "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        Jiri Kosina <jikos@...nel.org>,
        Henrik Rydberg <rydberg@...math.org>,
        Sam Bazely <sambazley@...tmail.com>,
        "Pierre-Loup A . Griffais" <pgriffais@...vesoftware.com>,
        Austin Palmer <austinp@...vesoftware.com>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 0/3] Logitech G920 fixes

On Fri, Oct 18, 2019 at 6:45 AM Andrey Smirnov <andrew.smirnov@...il.com> wrote:
>
> Everyone:
>
> This series contains patches to fix a couple of regressions in G920
> wheel support by hid-logitech-hidpp driver. Without the patches the
> wheel remains stuck in autocentering mode ("resisting" any attempt to
> trun) as well as missing support for any FF action.
>
> Thanks,
> Andrey Smirnov
>
> Changes since [v2]:
>
>      - Fixes a buggy validity check "HID: logitech-hidpp: rework
>        device validation" as pointed out by Benjamin Tissoires
>
>      - Marked "HID: logitech-hidpp: do all FF cleanup in
>        hidpp_ff_destroy()" as 5.2+ for stable
>
> Changes since [v1]:
>
>      - "HID: logitech-hidpp: split g920_get_config()" is changed to
>        not rely on devres and be a self contained patch
>
>      - Quirk driven behaviour of "HID: logitech-hidpp: add G920 device
>        validation quirk" is replaced with generic validation algorithm
>        of "HID: logitech-hidpp: rework device validation"
>
>      - Fix for a poteintial race condition is added in
>        "HID: logitech-hidpp: do all FF cleanup in hidpp_ff_destroy()"
>        as per suggestion by Benjamin Tissoires
>
>      - Collected Tested-by from Sam Bazely for "HID: logitech-hidpp:
>        split g920_get_config()" since that patch didn't change
>        significantly since [v1]
>
>      - Specified stable kernel versions I think the patches should
>        apply to (hopefully I got that right)
>
> [v2] lore.kernel.org/lkml/20191016182935.5616-1-andrew.smirnov@...il.com
> [v1] lore.kernel.org/lkml/20191007051240.4410-1-andrew.smirnov@...il.com
>
> Andrey Smirnov (3):
>   HID: logitech-hidpp: split g920_get_config()
>   HID: logitech-hidpp: rework device validation
>   HID: logitech-hidpp: do all FF cleanup in hidpp_ff_destroy()
>
>  drivers/hid/hid-logitech-hidpp.c | 237 +++++++++++++++++--------------
>  1 file changed, 131 insertions(+), 106 deletions(-)
>

Thanks a lot for the work on this series.

I gave a slight test of the series with a bunch of devices handled by
hid-logitech-hidpp without regressions.

Applied to for-5.4/upstream-fixes

Cheers,
Benjamin

> --
> 2.21.0
>