linux-kernel - Re: [PATCH -next 03/13] hwrng: exynos - use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v9smdrga.fsf%l.stelmach@samsung.com>
Date:   Fri, 18 Oct 2019 17:05:41 +0200
From:   Łukasz Stelmach <l.stelmach@...sung.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     <herbert@...dor.apana.org.au>, <mpm@...enic.com>, <arnd@...db.de>,
        <gregkh@...uxfoundation.org>, <nicolas.ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <ludovic.desroches@...rochip.com>,
        <f.fainelli@...il.com>, <rjui@...adcom.com>,
        <sbranden@...adcom.com>, <bcm-kernel-feedback-list@...adcom.com>,
        <eric@...olt.net>, <wahrenst@....net>, <kgene@...nel.org>,
        <krzk@...nel.org>, <khilman@...libre.com>, <dsaxena@...xity.net>,
        <patrice.chotard@...com>, <linux-crypto@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-rpi-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>,
        <linux-amlogic@...ts.infradead.org>,
        <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH -next 03/13] hwrng: exynos - use
 devm_platform_ioremap_resource() to simplify code

It was <2019-10-16 śro 12:46>, when YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/char/hw_random/exynos-trng.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>

Acked-by: Łukasz Stelmach <l.stelmach@...sung.com>

> diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c
> index b4b52ab..8e1fe3f 100644
> --- a/drivers/char/hw_random/exynos-trng.c
> +++ b/drivers/char/hw_random/exynos-trng.c
> @@ -109,7 +109,6 @@ static int exynos_trng_init(struct hwrng *rng)
>  static int exynos_trng_probe(struct platform_device *pdev)
>  {
>  	struct exynos_trng_dev *trng;
> -	struct resource *res;
>  	int ret = -ENOMEM;
>  
>  	trng = devm_kzalloc(&pdev->dev, sizeof(*trng), GFP_KERNEL);
> @@ -128,8 +127,7 @@ static int exynos_trng_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, trng);
>  	trng->dev = &pdev->dev;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	trng->mem = devm_ioremap_resource(&pdev->dev, res);
> +	trng->mem = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(trng->mem))
>  		return PTR_ERR(trng->mem);

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics