linux-kernel - Re: [PATCH] binder: Remove incorrect comment about vm_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 18 Oct 2019 17:47:27 +0200
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Jann Horn <jannh@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <christian@...uner.io>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] binder: Remove incorrect comment about vm_insert_page()
 behavior

On Fri, Oct 18, 2019 at 05:39:46PM +0200, Jann Horn wrote:
> vm_insert_page() does increment the page refcount, and just to be sure,
> I've confirmed it by printing page_count(page[0].page_ptr) before and after
> vm_insert_page(). It's 1 before, 2 afterwards, as expected.
> 
> Signed-off-by: Jann Horn <jannh@...gle.com>

Seems this has always been the case since its introduction:
a145dd411eb2 ("VM: add "vm_insert_page()" function")

Acked-by: Christian Brauner <christian.brauner@...ntu.com>