linux-kernel - Re: [PATCH] Updated iostats docs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191018094931.60df486f@lwn.net>
Date:   Fri, 18 Oct 2019 09:49:31 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Albert Vaca Cintora <albertvaka@...il.com>
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Updated iostats docs

On Wed, 16 Oct 2019 22:13:37 +0200
Albert Vaca Cintora <albertvaka@...il.com> wrote:

> revious docs mentioned 11 unsigned long fields, when the reality is that
> we have 15 fields with a mix of unsigned long and unsigned int.
> 
> Signed-off-by: Albert Vaca Cintora <albertvaka@...il.com>
> ---
>  Documentation/admin-guide/iostats.rst | 47 ++++++++++++++-------------
>  1 file changed, 24 insertions(+), 23 deletions(-)

I've applied this as an improvement over what's there now, but...

> diff --git a/Documentation/admin-guide/iostats.rst b/Documentation/admin-guide/iostats.rst
> index 5d63b18bd6d1..321aae8d7e10 100644
> --- a/Documentation/admin-guide/iostats.rst
> +++ b/Documentation/admin-guide/iostats.rst
> @@ -46,78 +46,79 @@ each snapshot of your disk statistics.
>  In 2.4, the statistics fields are those after the device name. In
>  the above example, the first field of statistics would be 446216.
>  By contrast, in 2.6+ if you look at ``/sys/block/hda/stat``, you'll
> -find just the eleven fields, beginning with 446216.  If you look at
> -``/proc/diskstats``, the eleven fields will be preceded by the major and
> +find just the 15 fields, beginning with 446216.  If you look at
> +``/proc/diskstats``, the 15 fields will be preceded by the major and

This document is full of information about the behavior of the 2.4 kernel,
which seems less than fully interesting in 2019.  It would be Really Nice
if somebody could go through and simply update this document to current
reality and discard all of the cruft.

Thanks,

jon