linux-kernel - Re: [PATCH] xen/netback: fix error path of xenvif_connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 19 Oct 2019 11:51:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jgross@...e.com
Cc:     xen-devel@...ts.xenproject.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, wei.liu@...nel.org, paul@....org,
        stable@...r.kernel.org
Subject: Re: [PATCH] xen/netback: fix error path of xenvif_connect_data()

From: Juergen Gross <jgross@...e.com>
Date: Fri, 18 Oct 2019 09:45:49 +0200

> xenvif_connect_data() calls module_put() in case of error. This is
> wrong as there is no related module_get().
> 
> Remove the superfluous module_put().
> 
> Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down")
> Signed-off-by: Juergen Gross <jgross@...e.com>
> Reviewed-by: Paul Durrant <paul@....org>

Applied and queued up for -stable.