linux-kernel - Re: [PATCH 6/6 v2] MMC: JZ4740: Add support for LPM.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47f6-5dab7580-33-5680128@176712317>
Date:   Sat, 19 Oct 2019 21:44:38 +0100
From:   "Ezequiel Garcia" <ezequiel.garcia@...labora.com>
To:     "Zhou Yanjie" <zhouyanjie@...o.com>
Cc:     "Ulf Hansson" <ulf.hansson@...aro.org>,
        "Paul Cercueil" <paul@...pouillou.net>, linux-mips@...r.kernel.org,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        linux-mmc@...r.kernel.org 
        <linux-mmc@...r.kernel.org>, "DTML" <devicetree@...r.kernel.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Paul Burton" <paul.burton@...s.com>,
        "Mark Rutland" <mark.rutland@....com>, syq@...ian.org,
        "Linus Walleij" <linus.walleij@...aro.org>, armijn@...ldur.nl,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "YueHaibing" <yuehaibing@...wei.com>,
        "Mathieu Malaterre" <malat@...ian.org>
Subject: Re: [PATCH 6/6 v2] MMC: JZ4740: Add support for 
 LPM.

On Friday, October 18, 2019 13:54 -03, Zhou Yanjie <zhouyanjie@...o.com> wrote: 
 

> 
> >
> > I also have a general question. Should we perhaps rename the driver
> > from jz4740_mmc.c to ingenic.c (and the file for the DT bindings, the
> > Kconfig, etc), as that seems like a more appropriate name? No?
> 
> I am very much in favor of this proposal. Now jz4740_mmc.c is not only used
> for the JZ4740 processor, it is also used for JZ4725, JZ4760, JZ4770, JZ4780
> and X1000, and now Ingenic's processor is no longer named after JZ47xx,
> it is divided into three product lines: M, T, and X. It is easy to cause 
> some
> misunderstandings by using jz4740_mmc.c. At the same time, I think that
> some register names also need to be adjusted. For example, the STLPPL
> register name has only appeared in JZ4730 and JZ4740, and this register
> in all subsequent processors is called CTRL. This time I was confused by
> the STLPPL when I added drivers for the JZ4760's and X1000's LPM.
> 

I am very much against renamings, for several reasons. As Paul already mentioned, it's pointless and just adds noise to the git-log, making history harder to recover. Driver file names don't really have to reflect the device exactly. For the compatibility list, it's far easier to just git-grep for compatible strings, or git-grep Documentation and/or Kconfig.

Renaming macros and register names, is equally pointless and equally git-history invasive. Simply adding some documentation is enough.

Thanks,
Ezequiel