linux-kernel - Re: [PATCH -next] Bluetooth: btusb: Remove return statement in btintel_reset_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <859945F9-E674-4906-A18D-BCA6027AA535@holtmann.org>
Date:   Sat, 19 Oct 2019 09:57:06 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Amit K Bag <amit.k.bag@...el.com>,
        Chethan T N <chethan.tumkur.narayan@...el.com>,
        Raghuram Hegde <raghuram.hegde@...el.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        clang-built-linux@...glegroups.com,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH -next] Bluetooth: btusb: Remove return statement in
 btintel_reset_to_bootloader

Hi Nathan,

> When building with Clang and CONFIG_BT_INTEL unset, the following error
> occurs:
> 
> In file included from drivers/bluetooth/hci_ldisc.c:34:
> drivers/bluetooth/btintel.h:188:2: error: void function
> 'btintel_reset_to_bootloader' should not return a value [-Wreturn-type]
>        return -EOPNOTSUPP;
>        ^      ~~~~~~~~~~~
> 1 error generated.
> 
> Remove the unneeded return statement to fix this.
> 
> Fixes: b9a2562f4918 ("Bluetooth: btusb: Trigger Intel FW download error recovery")
> Link: https://github.com/ClangBuiltLinux/linux/issues/743
> Reported-by: <ci_notify@...aro.org>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
> drivers/bluetooth/btintel.h | 1 -
> 1 file changed, 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel