linux-kernel - Re: [PATCH 2/2] xfs: replace homemade binary search

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191019081216.GA21691@infradead.org>
Date:   Sat, 19 Oct 2019 01:12:16 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Thomas Meyer <thomas@...3r.de>
Cc:     linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org
Subject: Re: [PATCH 2/2] xfs: replace homemade binary search

On Sat, Oct 19, 2019 at 09:20:33AM +0200, Thomas Meyer wrote:
> use newly introduced bsearch_idx instead.
> 
> Signed-off-by: Thomas Meyer <thomas@...3r.de>

What is the point?  This adds more code, and makes it slower by
adding an indirect function call.