linux-kernel - Re: [PATCH 2/2] platform/x86: huawei-wmi: No need to check for battery name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <482708553d5dc6cec2d4513391d81a22928fd4b2.camel@gmail.com>
Date:   Sat, 19 Oct 2019 20:33:14 -0400
From:   ayman.bagabas@...il.com
To:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Takashi Iwai <tiwai@...e.de>, Mattias Jacobsson <2pi@....nu>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        kbuild test robot <lkp@...el.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] platform/x86: huawei-wmi: No need to check for
 battery name

On Fri, 2019-10-18 at 18:42 -0400, Ayman Bagabas wrote:
> No need to check for battery name, we already check if the WMI
> function is
> available in huawei_wmi_battery_setup.

Signed-off-by: Ayman Bagabas <ayman.bagabas@...il.com>

Thank you,
Ayman
> ---
>  drivers/platform/x86/huawei-wmi.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/huawei-wmi.c
> b/drivers/platform/x86/huawei-wmi.c
> index 26041d44286a..7373a65a61d3 100644
> --- a/drivers/platform/x86/huawei-wmi.c
> +++ b/drivers/platform/x86/huawei-wmi.c
> @@ -471,10 +471,6 @@ static
> DEVICE_ATTR_RW(charge_control_thresholds);
>  
>  static int huawei_wmi_battery_add(struct power_supply *battery)
>  {
> -	/* Huawei laptops come with one battery only */
> -	if (strcmp(battery->desc->name, "BAT") != 1)
> -		return -ENODEV;
> -
>  	device_create_file(&battery->dev,
> &dev_attr_charge_control_start_threshold);
>  	device_create_file(&battery->dev,
> &dev_attr_charge_control_end_threshold);
>