linux-kernel - Re: [RFT 1/3] power: supply: ab8500: Cleanup probe in reverse order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 20 Oct 2019 15:23:52 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Krzysztof Kozlowski <krzk@...nel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Linux PM list <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFT 1/3] power: supply: ab8500: Cleanup probe in reverse order

Hi,

On Wed, Oct 16, 2019 at 10:33:12AM +0200, Linus Walleij wrote:
> On Fri, Oct 4, 2019 at 5:07 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> 
> > It is logical to cleanup in probe's error path in reverse order to
> > previous actions.  It also makes easier to add additional goto labels
> > within this error path.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> 
> For all 3 patches:
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> 
> The battery charging code is currently disabled on ux500 simply
> because no platforms with batteries were available for testing
> or supported by any device trees.
> 
> This is getting fix: PostmarketOS is brewing patches for enabling
> all Ux500-based Samsung phones, all with batteries. So we will
> soon be able to test and turn this on.
> 
> The patches are fine to merge, however notice that we are
> refactoring all drivers using ADC through the IIO tree:
> https://lore.kernel.org/linux-iio/20191011071805.5554-4-linus.walleij@linaro.org/
> https://lore.kernel.org/linux-iio/20191011071805.5554-2-linus.walleij@linaro.org/
> https://lore.kernel.org/linux-iio/20191011071805.5554-3-linus.walleij@linaro.org/
> 
> It would be nice if we could avoid colissions.

Thanks, I merged your immutable branch for the ADC work
and this patchset.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)