[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20191021162115.GA21883@kozik-lap>
Date: Mon, 21 Oct 2019 18:21:15 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alim Akhtar <alim.akhtar@...il.com>
Cc: Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Kukjin Kim <kgene@...nel.org>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: exynos: Rename children of SysRAM node to
"sram"
On Mon, Oct 21, 2019 at 09:37:24PM +0530, Alim Akhtar wrote:
> On Mon, Oct 21, 2019 at 8:45 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >
> > The device node name should reflect generic class of a device so rename
> > the children of SysRAM node to "smp-sysram". This will be also in sync
> Typo "smp-sram"
Thanks, indeed.
> > with upcoming DT schema. No functional change.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> > ---
> Looks good to me.
Shall I add your review-tag?
Best regards,
Krzysztof
>
> > arch/arm/boot/dts/exynos3250.dtsi | 4 ++--
> > arch/arm/boot/dts/exynos4210-universal_c210.dts | 6 +++---
> > arch/arm/boot/dts/exynos4210.dtsi | 4 ++--
> > arch/arm/boot/dts/exynos4412.dtsi | 4 ++--
> > arch/arm/boot/dts/exynos5250.dtsi | 4 ++--
> > arch/arm/boot/dts/exynos54xx.dtsi | 4 ++--
> > 6 files changed, 13 insertions(+), 13 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> > index b016b0b68306..044e5da64a76 100644
> > --- a/arch/arm/boot/dts/exynos3250.dtsi
> > +++ b/arch/arm/boot/dts/exynos3250.dtsi
> > @@ -145,12 +145,12 @@
> > #size-cells = <1>;
> > ranges = <0 0x02020000 0x40000>;
> >
> > - smp-sysram@0 {
> > + smp-sram@0 {
> > compatible = "samsung,exynos4210-sysram";
> > reg = <0x0 0x1000>;
> > };
> >
> > - smp-sysram@...00 {
> > + smp-sram@...00 {
> > compatible = "samsung,exynos4210-sysram-ns";
> > reg = <0x3f000 0x1000>;
> > };
> > diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > index 09d3d54d09ff..a1bdf7830a87 100644
> > --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > @@ -590,16 +590,16 @@
> > };
> >
> > &sysram {
> > - smp-sysram@0 {
> > + smp-sram@0 {
> > status = "disabled";
> > };
> >
> > - smp-sysram@...0 {
> > + smp-sram@...0 {
> > compatible = "samsung,exynos4210-sysram";
> > reg = <0x5000 0x1000>;
> > };
> >
> > - smp-sysram@...00 {
> > + smp-sram@...00 {
> > status = "disabled";
> > };
> > };
> > diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
> > index 554819ae1446..b4466232f0c1 100644
> > --- a/arch/arm/boot/dts/exynos4210.dtsi
> > +++ b/arch/arm/boot/dts/exynos4210.dtsi
> > @@ -79,12 +79,12 @@
> > #size-cells = <1>;
> > ranges = <0 0x02020000 0x20000>;
> >
> > - smp-sysram@0 {
> > + smp-sram@0 {
> > compatible = "samsung,exynos4210-sysram";
> > reg = <0x0 0x1000>;
> > };
> >
> > - smp-sysram@...00 {
> > + smp-sram@...00 {
> > compatible = "samsung,exynos4210-sysram-ns";
> > reg = <0x1f000 0x1000>;
> > };
> > diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
> > index 5022aa574b26..48868947373e 100644
> > --- a/arch/arm/boot/dts/exynos4412.dtsi
> > +++ b/arch/arm/boot/dts/exynos4412.dtsi
> > @@ -195,12 +195,12 @@
> > #size-cells = <1>;
> > ranges = <0 0x02020000 0x40000>;
> >
> > - smp-sysram@0 {
> > + smp-sram@0 {
> > compatible = "samsung,exynos4210-sysram";
> > reg = <0x0 0x1000>;
> > };
> >
> > - smp-sysram@...00 {
> > + smp-sram@...00 {
> > compatible = "samsung,exynos4210-sysram-ns";
> > reg = <0x2f000 0x1000>;
> > };
> > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> > index e1f0215e3985..ec983283f573 100644
> > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > @@ -171,12 +171,12 @@
> > #size-cells = <1>;
> > ranges = <0 0x02020000 0x30000>;
> >
> > - smp-sysram@0 {
> > + smp-sram@0 {
> > compatible = "samsung,exynos4210-sysram";
> > reg = <0x0 0x1000>;
> > };
> >
> > - smp-sysram@...00 {
> > + smp-sram@...00 {
> > compatible = "samsung,exynos4210-sysram-ns";
> > reg = <0x2f000 0x1000>;
> > };
> > diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi
> > index f78dee801cd9..8aa5117e58ce 100644
> > --- a/arch/arm/boot/dts/exynos54xx.dtsi
> > +++ b/arch/arm/boot/dts/exynos54xx.dtsi
> > @@ -62,12 +62,12 @@
> > #size-cells = <1>;
> > ranges = <0 0x02020000 0x54000>;
> >
> > - smp-sysram@0 {
> > + smp-sram@0 {
> > compatible = "samsung,exynos4210-sysram";
> > reg = <0x0 0x1000>;
> > };
> >
> > - smp-sysram@...00 {
> > + smp-sram@...00 {
> > compatible = "samsung,exynos4210-sysram-ns";
> > reg = <0x53000 0x1000>;
> > };
> > --
> > 2.17.1
> >
>
>
> --
> Regards,
> Alim
Powered by blists - more mailing lists