linux-kernel - Re: [PATCH v2 04/12] arm64: docs: cpu-feature-registers: Document ID_AA64PFR1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191021191818.GH4691@sirena.co.uk>
Date:   Mon, 21 Oct 2019 20:18:18 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Dave Martin <Dave.Martin@....com>
Cc:     Alex Bennée <alex.bennee@...aro.org>,
        Paul Elliott <paul.elliott@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Yu-cheng Yu <yu-cheng.yu@...el.com>,
        Amit Kachhap <amit.kachhap@....com>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        linux-arch@...r.kernel.org, Eugene Syromiatnikov <esyr@...hat.com>,
        Szabolcs Nagy <szabolcs.nagy@....com>,
        "H.J. Lu" <hjl.tools@...il.com>, Andrew Jones <drjones@...hat.com>,
        Kees Cook <keescook@...omium.org>,
        Arnd Bergmann <arnd@...db.de>, Jann Horn <jannh@...gle.com>,
        Richard Henderson <richard.henderson@...aro.org>,
        Kristina Martšenko <kristina.martsenko@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-arm-kernel@...ts.infradead.org,
        Florian Weimer <fweimer@...hat.com>,
        linux-kernel@...r.kernel.org, Sudakshina Das <sudi.das@....com>,
        Suzuki Poulose <suzuki.poulose@....com>
Subject: Re: [PATCH v2 04/12] arm64: docs: cpu-feature-registers: Document
 ID_AA64PFR1_EL1

On Fri, Oct 11, 2019 at 03:51:49PM +0100, Dave Martin wrote:
> On Fri, Oct 11, 2019 at 02:19:48PM +0100, Alex Bennée wrote:

> > > -  4) ID_AA64ISAR1_EL1 - Instruction set attribute register 1
> > > +  5) ID_AA64ISAR1_EL1 - Instruction set attribute register 1

> > If I'm not mistaken .rst has support for auto-enumeration if the #
> > character is used. That might reduce the pain of re-numbering in future.

> Ack, though it would be good to go one better and generate this document
> from the cpufeature.c tables (or from some common source).  The numbers
> are relatively easy to maintain -- remembering to update the document
> at all seems the bigger maintenance headache right now.

I agree, it'd be better if the table were autogenerated.  Having tried
doing the modification to # it does mean that the document looks a bit
weird when viewing it as a text file in the kernel source which TBH is
how I suspect a lot of people will view it so given the infrequency with
which new registers are added I'm not sure it's worth it.

> I think this particular patch is superseded by similar fixes from other
> people, just not in torvalds/master yet.

Nor in -next for the minute :/

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)