linux-kernel - Re: [PATCH v2 0/4] KVM: x86/vPMU: Efficiency optimization by reusing last created perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Oct 2019 10:26:01 +0800
From:   Like Xu <like.xu@...ux.intel.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     kvm@...r.kernel.org, peterz@...radead.org,
        Jim Mattson <jmattson@...gle.com>, rkrcmar@...hat.com,
        sean.j.christopherson@...el.com, vkuznets@...hat.com,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        ak@...ux.intel.com, wei.w.wang@...el.com, kan.liang@...el.com,
        like.xu@...el.com, ehankland@...gle.com, arbel.moshe@...cle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] KVM: x86/vPMU: Efficiency optimization by reusing
 last created perf_event

On 2019/10/13 17:15, Like Xu wrote:
...

Hi Paolo,

Do you have any concerns or comments for the KVM codes (the last two 
patches) about this vPMU efficiency optimization?

Thanks,
Like Xu

> 
> ---
> Changes in v2:
> - use perf_event_pause() to disable, read, reset by only one lock;
> - use __perf_event_read_value() after _perf_event_disable();
> - replace bitfields with 'u8 event_count; bool need_cleanup;';
> - refine comments and commit messages;
> - fix two issues reported by kbuild test robot for ARCH=[nds32|sh]
> 
> v1:
> https://lore.kernel.org/kvm/20190930072257.43352-1-like.xu@linux.intel.com/
> 
> Like Xu (4):
>    perf/core: Provide a kernel-internal interface to recalibrate event
>      period
>    perf/core: Provide a kernel-internal interface to pause perf_event
>    KVM: x86/vPMU: Reuse perf_event to avoid unnecessary
>      pmc_reprogram_counter
>    KVM: x86/vPMU: Add lazy mechanism to release perf_event per vPMC
> 
>   arch/x86/include/asm/kvm_host.h | 17 +++++++
>   arch/x86/kvm/pmu.c              | 88 ++++++++++++++++++++++++++++++++-
>   arch/x86/kvm/pmu.h              | 15 +++++-
>   arch/x86/kvm/pmu_amd.c          | 14 ++++++
>   arch/x86/kvm/vmx/pmu_intel.c    | 27 ++++++++++
>   arch/x86/kvm/x86.c              | 12 +++++
>   include/linux/perf_event.h      | 10 ++++
>   kernel/events/core.c            | 44 ++++++++++++++---
>   8 files changed, 216 insertions(+), 11 deletions(-)
>