linux-kernel - RE: [EXT] [RFT] dmaengine: fsl-qdma: Handle invalid qdma-queue0 IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB443161476574A4424B0B55B2ED690@VI1PR04MB4431.eurprd04.prod.outlook.com>
Date:   Mon, 21 Oct 2019 09:54:20 +0000
From:   Peng Ma <peng.ma@....com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Vinod Koul <vkoul@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Wen He <wen.he_1@....com>, Jiaheng Fan <jiaheng.fan@....com>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [RFT] dmaengine: fsl-qdma: Handle invalid qdma-queue0 IRQ

Hi Krzysztof,

Thanks for your patch.
Reviewed-by: Peng Ma <peng.ma@....com>
Tested-by: Peng Ma <peng.ma@....com>

Best Regards,
Peng
>-----Original Message-----
>From: Krzysztof Kozlowski <krzk@...nel.org>
>Sent: 2019年10月4日 23:08
>To: Vinod Koul <vkoul@...nel.org>; Dan Williams <dan.j.williams@...el.com>;
>Peng Ma <peng.ma@....com>; Wen He <wen.he_1@....com>; Jiaheng Fan
><jiaheng.fan@....com>; Krzysztof Kozlowski <krzk@...nel.org>;
>dmaengine@...r.kernel.org; linux-kernel@...r.kernel.org
>Subject: [EXT] [RFT] dmaengine: fsl-qdma: Handle invalid qdma-queue0 IRQ
>
>Caution: EXT Email
>
>platform_get_irq_byname() might return -errno which later would be cast to an
>unsigned int and used in IRQ handling code leading to usage of wrong ID and
>errors about wrong irq_base.
>
>Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>
>---
>
>Not marking as cc-stable as this was not reproduced and not tested.
>---
> drivers/dma/fsl-qdma.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c index
>06664fbd2d91..89792083d62c 100644
>--- a/drivers/dma/fsl-qdma.c
>+++ b/drivers/dma/fsl-qdma.c
>@@ -1155,6 +1155,9 @@ static int fsl_qdma_probe(struct platform_device
>*pdev)
>                return ret;
>
>        fsl_qdma->irq_base = platform_get_irq_byname(pdev,
>"qdma-queue0");
>+       if (fsl_qdma->irq_base < 0)
>+               return fsl_qdma->irq_base;
>+
>        fsl_qdma->feature = of_property_read_bool(np, "big-endian");
>        INIT_LIST_HEAD(&fsl_qdma->dma_dev.channels);
>
>--
>2.17.1