linux-kernel - Re: [PATCH v3 1/4] perf/core,x86: introduce sync_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191021102706.GE1800@hirez.programming.kicks-ass.net>
Date:   Mon, 21 Oct 2019 12:27:06 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Alexey Budankov <alexey.budankov@...ux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Stephane Eranian <eranian@...gle.com>,
        Ian Rogers <irogers@...gle.com>,
        Song Liu <songliubraving@...com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/4] perf/core,x86: introduce sync_task_ctx() method
 at struct pmu

On Fri, Oct 18, 2019 at 12:42:44PM +0300, Alexey Budankov wrote:
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 61448c19a132..60bf17af69f0 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -409,6 +409,13 @@ struct pmu {
>  	 */
>  	size_t				task_ctx_size;
>  
> +	/*
> +	 * PMU specific parts of task perf event context (i.e. ctx->task_ctx_data)
> +	 * can be synchronized using this function. See Intel LBR callstack support
> +	 * implementation and Perf core context switch handling callbacks for usage
> +	 * examples.

You're forgetting to mark this: Optional

> +	 */

> +	void (*sync_task_ctx)		(void *one, void *another);

The traditional argment names for context switching functions are prev
and next.