linux-kernel - Re: [PATCH net-next 13/16] net: dsa: mv88e6xxx: use ports list to map bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6170cf3-233a-b632-9ab9-26101793f315@gmail.com>
Date:   Sun, 20 Oct 2019 19:52:07 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vivien Didelot <vivien.didelot@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     linux-kernel@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 13/16] net: dsa: mv88e6xxx: use ports list to map
 bridge



On 10/19/2019 8:19 PM, Vivien Didelot wrote:
> Instead of digging into the other dsa_switch structures of the fabric
> and relying too much on the dsa_to_port helper, use the new list
> of switch fabric ports to remap the Port VLAN Map of local bridge
> group members or remap the Port VLAN Table entry of external bridge
> group members.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...il.com>
> ---

[snip]

> -		for (port = 0; port < ds->num_ports; ++port) {
> -			if (dsa_to_port(ds, port)->bridge_dev == br) {
> -				err = mv88e6xxx_pvt_map(chip, dev, port);
> +	list_for_each_entry(dp, &dst->ports, list) {
> +		/* Remap the Port VLAN Map of local bridge group members and
> +		 * remap the PVT entry of external bridge group members.
> +		 */

If you do a v2, I would tend to put these comments under the appropriate
branches taken below for clarify although the code is actually clearer
this want than it was before IMHO, so up to you :)

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian