linux-kernel - Re: [PATCH v2 1/9] mfd: cs5535-mfd: Use PLATFORM_DEVID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191021113316.GA4365@dell>
Date:   Mon, 21 Oct 2019 12:33:16 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Daniel Thompson <daniel.thompson@...aro.org>
Cc:     arnd@...db.de, broonie@...nel.org, linus.walleij@...aro.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        baohua@...nel.org, stephan@...hold.net
Subject: Re: [PATCH v2 1/9] mfd: cs5535-mfd: Use PLATFORM_DEVID_* defines and
 tidy error message

On Mon, 21 Oct 2019, Daniel Thompson wrote:

> On Mon, Oct 21, 2019 at 11:58:14AM +0100, Lee Jones wrote:
> > In most contexts '-1' doesn't really mean much to the casual observer.
> > In almost all cases, it's better to use a human readable define.  In
> > this case PLATFORM_DEVID_* defines have already been provided for this
> > purpose.
> > 
> > While we're here, let's be specific about the 'MFD devices' which
> > failed.  It will help when trying to distinguish which of the 2 sets
> > of sub-devices we actually failed to register.
> 
> No objections... but won't the tag added by dev_err() already
> disambiguate?

The difference will be between CS5532 and  CS5532 OLPC.

Please see patch 4 in the series.

> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > ---
> >  drivers/mfd/cs5535-mfd.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/mfd/cs5535-mfd.c b/drivers/mfd/cs5535-mfd.c
> > index f1825c0ccbd0..2c47afc22d24 100644
> > --- a/drivers/mfd/cs5535-mfd.c
> > +++ b/drivers/mfd/cs5535-mfd.c
> > @@ -127,10 +127,11 @@ static int cs5535_mfd_probe(struct pci_dev *pdev,
> >  		cs5535_mfd_cells[i].id = 0;
> >  	}
> >  
> > -	err = mfd_add_devices(&pdev->dev, -1, cs5535_mfd_cells,
> > +	err = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, cs5535_mfd_cells,
> >  			      ARRAY_SIZE(cs5535_mfd_cells), NULL, 0, NULL);
> >  	if (err) {
> > -		dev_err(&pdev->dev, "MFD add devices failed: %d\n", err);
> > +		dev_err(&pdev->dev,
> > +			"Failed to add CS5532 sub-devices: %d\n", err);
> 
>                                            ^^^
> 
> Typo (and MODULE_DESCRIPTION() says this is a driver for CS5536 too).
> Once that is fixed:
> Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>

Ta.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog